Removed defer attribute from the avo.base.css stylesheet tag #3635
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`defer` isn't a valid attribute for a `<link>` tag - it is for `<script>` tags and having it here is invalid html. I think this is also causing loading issues in google chrome for me when I redirect from avo to my main app. I've removed defer from the `<link>` tag. This should make the html valid and shouldn't have any bad effects (as it shouldn't be used on a `<link>` tag anyway).
|
Code Climate has analyzed commit ed562bb and detected 0 issues on this pull request. View more on Code Climate. |
Paul-Bob
approved these changes
Feb 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When you load a page in avo the html
<link>tag to loadavo.base.cssit ha adeferattribute on it.deferisn't a valid attribute for a<link>tag - it is for<script>tags and having it here is invalid html. I think this is also causing loading issues in google chrome for me when I redirect from avo to my main app.I've removed defer from the
<link>tag. This should make the html valid and shouldn't have any bad effects (as it shouldn't be used on a<link>tag anyway).Fixes # (issue)
Checklist:
Screenshots & recording
Manual review steps
Manual reviewer: please leave a comment with output from the test if that's the case.